vanilla rocks and modded minerals and plastics get tilesets#78
Open
seventh-june wants to merge 9 commits intoGTNewHorizons:masterfrom
Open
vanilla rocks and modded minerals and plastics get tilesets#78seventh-june wants to merge 9 commits intoGTNewHorizons:masterfrom
seventh-june wants to merge 9 commits intoGTNewHorizons:masterfrom
Conversation
rock girl adds rocks
rock girl adds minerals
seventh-june
changed the title
rock girl adds oil byproducts, it still counts
seventh-june
changed the title
Author
|
Dream-Master
added
🚧 Testing on Zeta
Member
|
This pr cause a crash |
Author
all fixed now |
Dream-Master
added
the
🚧 Testing on Zeta
Member
|
@seventh-june Run './gradlew spotlessApply' to fix all violations. |
UltraProdigy
requested changes
Feb 17, 2026
Member
UltraProdigy
left a comment
UltraProdigy
left a comment
There was a problem hiding this comment.
Okay atraditional review but bear with me. Tested in game.
In game issues:
- Alabastor showing key not name
- Amber 2 showing key not name
- Apatite ID is labeled & textured as Topaz
- Can't see deepslate
- Porcelain not there
File wise:
- Jade pngs are duplicated in the fluorite folder
These blocks need either a recipe or to be added to the same chisel map as pre-existing blocks:
- Alabastor
- Amber 2 -> Needs combination w/ Amber
- Apatite / Topaz -> Needs combination w/ Apatite / Topaz
- Blackstone -> Needs combination w/ EFR
- Charoite
- Coralstone
- Dark Prismarine -> Needs combination w/ Botania
- Deepslate -> Needs combination w/ EFR
- Dripstone
- Fluorite
- Jade
- Labradorite
- Nether Quartz -> Needs combination w/ Minecraft
- Onyx
- Opal -> Needs combination w/ GT
- Plastic
- Porcelain
- Prismarine -> Need combination w/ Botania
- Purpurite -> Might need combination w/ Purpur
- Rhodochrosite
- Spinel -> Needs combination w/ GT
- Tuff -> Needs combination w/ EFR
Also pretty much everything will need an NEI group but that's another PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rock girl adds rocks
added blocksets for:
Basalt, Tuff, Purpurite (IRL mineral which inspired Purpur), Dripstone, Prismarine, Dark Prismarine, Coralstone (informal name for limestone deposits made of fossil reefs), Amethyst, and Blackstone.
(recipes for these will have to be handled outside of Chisel and so are not included in this PR)